Repository navigation
feat(boto3): Add SNS extension - #8142
Open
pabloDeputter wants to merge 6 commits into
Open
pabloDeputter wants to merge 6 commits into
pabloDeputter wants to merge 6 commits into
Conversation
Contributor
Coverage Results 📊✅ 58190 passed | ⏭️ 3014 skipped | Total: 61204 | Pass Rate: 95.08% | Execution Time: 158m 9s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00% (51 of 51 changed executable lines covered; target 80%). Changed files with executable lines (2)
Coverage diff@@ Coverage Diff @@
## master #8142 +/-##
==========================================
+ Coverage 90.31% 90.40% +0.09%
==========================================
Files 203 199 -4
Tracked lines 26933 21406 -5527
Branches 10058 7428 -2630
==========================================
- Hits 24321 19350 -4971
+ Misses 2612 2056 -556
+ Partials 1518 1234 -284Generated by Coverage Action |
pabloDeputter
marked this pull request as ready for review
October 28, 2026 15:05
…-extension Co-Authored-By: Johannes Daxböck <114897+dingsdax@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the SNS extension to the boto3 integration, now SNS
PublishandPublishBatchbecomequeue.publishspans so they show up in the Queues insight; all other operations stay onrpc:Publish,PublishBatch:queue.publish, kindproducer(default isclient), namedsend <topic>Adds the following attributes:
messaging.system(aws.sns),messaging.operation.type(send) andmessaging.operation.name(publish) on the publish APIs (all from OTel)messaging.batch.message_countonPublishBatch,messaging.message.idonPublishaws.sns.topic.arnandmessaging.destination.name(topic name) on every API withTopicArn,ResourceArnor a topicTargetArn; destination name also fromCreateTopic'sNameOther changes:
PhoneNumberand platform-endpointTargetArnpublishes getmessaging.destination.name=[Filtered](send [Filtered])Issues
Resolves #7573 & PY-2804